Update factory

trento-project · Mar 20, 2024 · 312a52d · 312a52d
1 parent 2e1573b
commit 312a52d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/test/support/factory.ex b/test/support/factory.ex
@@ -23,10 +23,20 @@ defmodule Wanda.Factory do
     %Catalog.Check{
       id: UUID.uuid4(),
       name: Faker.StarWars.character(),
+      group: Faker.Company.name(),
+      description: Faker.Lorem.sentence(),
+      remediation: Faker.Lorem.sentence(),
+      metadata: %{
+        target_type: Faker.StarWars.character(),
+        cluster_type: Faker.Lorem.sentence(),
+        provider:
+          Enum.take_random(["azure", "nutanix", "kvm", "vmware, gcp, aws"], Enum.random(0..6))
+      },
       severity: Enum.random([:critical, :warning, :passing]),
       facts: build_list(10, :catalog_fact),
       values: build_list(10, :catalog_value),
       expectations: build_list(10, :catalog_expectation),
+      when: Faker.Lorem.sentence(),
       premium: Enum.random([false, true])
     }
   end

diff --git a/test/wanda_web/views/v1/catalog_view_test.exs b/test/wanda_web/views/v1/catalog_view_test.exs
@@ -36,7 +36,7 @@ defmodule WandaWeb.V1.CatalogViewTest do
     end
   end
 
-  test "renders catalog.json v1 without additional properties " do
+  test "renders catalog.json like expected in the v1 schema" do
     checks = [
       build(:check, expectations: build_list(2, :catalog_expectation, type: :expect)),
       build(:check, expectations: build_list(2, :catalog_expectation, type: :expect_same))