Barbecue images #1803
Barbecue images #1803
Conversation
dottorblaster
force-pushed
the
barbecue-images
branch
4 times, most recently
from
9441943 to
6c8aa02
Compare
dottorblaster
force-pushed
the
barbecue-images
branch
from
6c8aa02 to
6db845d
Compare
nelsonkopliku
force-pushed
the
barbecue-images
branch
from
78b5a46 to
9f4a142
Compare
jamie-suse
force-pushed
the
barbecue-images
branch
from
11e8057 to
ea153d4
Compare
dottorblaster
force-pushed
the
barbecue-images
branch
2 times, most recently
from
d1c1144 to
d6919d6
Compare
dottorblaster
force-pushed
the
barbecue-images
branch
from
d6919d6 to
959ff92
Compare
dottorblaster
force-pushed
the
barbecue-images
branch
3 times, most recently
from
5629fa3 to
cf234cb
Compare
There was a problem hiding this comment.
Good job.
No critical blockers for this iteration.
However, besides what commented, here's a few more notes:
several checks related to corosync cmap ctl fail
error while executing corosynccmap-ctl: exec: "corosync-cmapctl": executable file not found in $PATH
package version related checks have a similar issue
error while fetching package version: package corosync is not installed exit status 1
Here /clusters/597a00db-5920-5033-b3b4-1dc98ca8718a/executions/last/373DB8/host/hana_node01 there is a failure because something can not be found in rhai
Unknown property 'value' - a getter is not registered for type '()' (line 4, position 55)
Either the check needs to cover the case or we are missing something in the fake gathered fact.
Here /clusters/597a00db-5920-5033-b3b4-1dc98ca8718a/executions/last/816815/host/hana_node01 there is a failure because
systemd gatherer not initialized properly
We need extra iterations and extra effort to get faked agent cover further scenarios and maximize their value.
| '7E0221': CRITICAL, | ||
| '822E47': CRITICAL, | ||
| '845CC9': PASSING, | ||
| A1244C: CRITICAL, |
There was a problem hiding this comment.
Not a blocker, but what about having all check ids as string?
There was a problem hiding this comment.
It's just Prettier, I will give it a try but I think the formatter will just revert every attempt of mine 👍
| @@ -17,6 +17,12 @@ export const availableClusters = [ | |||
| sid: '', | |||
| type: 'Unknown', | |||
| }, | |||
| { | |||
| id: 'fa0d74a3-9240-5d9e-99fa-61c4137acf81', | |||
There was a problem hiding this comment.
This is hana_cluster_2's id. It should be 597a00db-5920-5033-b3b4-1dc98ca8718a
| context('HANA scale-up checks', () => { | ||
| const clusterID = 'd2522281-2c76-52dc-8500-10bdf2cc6664'; | ||
| context('HANA scale-up checks', () => { | ||
| const clusterID = '597a00db-5920-5033-b3b4-1dc98ca8718a'; |
There was a problem hiding this comment.
To avoid duplication and error we could get this id from availableClusters
| ['DC5429', PASSING], | ||
| ['F50AF5', PASSING], | ||
| ]; | ||
| const expectedCheckResults = { |
There was a problem hiding this comment.
There are 7 (if I counted correctly 😄 ) missing checks from this expectation list. Since in the test we are selecting them all it might make sense to have an expectation for all of them as well.
| @@ -54,7 +54,7 @@ context('Hosts Overview', () => { | |||
| .then((i) => { | |||
| cy.get('@hostRow') | |||
| .eq(i) | |||
| .should('contain', host.agentVersion.slice(0, 15)); | |||
| .should('contain', host.agentVersion.slice(0, 13)); | |||
There was a problem hiding this comment.
Pls help. What did change here?
There was a problem hiding this comment.
Agent's version is not coming from a fixture, it's the actual version of the agent, so we must limit the slice to a fewer number of chars given that the commit sha will often change
| @@ -179,13 +179,15 @@ context('Hosts Overview', () => { | |||
| }); | |||
|
|
|||
| it('should change the health to warning if saptune is not installed', () => { | |||
| cy.contains('button', '2').click(); | |||
There was a problem hiding this comment.
Is this about navigating to the page where the relevant host is, since we added two?
dottorblaster
force-pushed
the
barbecue-images
branch
2 times, most recently
from
f9d3461 to
53cc8b2
Compare
dottorblaster
force-pushed
the
barbecue-images
branch
from
53cc8b2 to
53bd726
Compare
dottorblaster
force-pushed
the
barbecue-images
branch
from
53bd726 to
04df557
Compare
Description
Integrating Barbecue images in our CI for end to end tests and in our local development environment.
How was this tested?
End to end tests were updated to match new values and added where missing.