Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PageObject pattern Clusters Overview tests. #3266

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

vicenteqa
Copy link
Contributor

@vicenteqa vicenteqa commented Jan 31, 2025

Description

Apply page object pattern to clusters overview tests
Key points:

  • Some methods from commands file have been removed and now they are in po files
  • Skipped & WIP test has been refactored but still left as WIP as the scope of this task was different

Bonus track:

  • I removed a couple of unused parameters in visit methods from two page objects as required by @nelsonkopliku in a previus pr review
  • I also removed a validation that was done with data-testid for consistency and to end up not using them after the refactor finishes.

No changes required in docs.

Fixes # (issue)

Did you add the right label?

Remember to add the right labels to this PR.

  • DONE

How was this tested?

Describe the tests that have been added/changed for this new behavior.

  • DONE

Did you update the documentation?

Remember to ask yourself if your PR requires changes to the following documentation:

Add a documentation PR or write that no changes are required for the documentation.

  • DONE

@vicenteqa vicenteqa added the test label Feb 5, 2025
@vicenteqa vicenteqa marked this pull request as ready for review February 5, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant