Drop Puppet 5, support Puppet 7

treydock · Mar 6, 2021 · 20aa773 · 20aa773
1 parent 7ce7e0e
commit 20aa773
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 38 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -15,22 +15,22 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - ruby: 2.4.9
-            puppet: 5
-            fixtures: .fixtures.yml
-            allow_failure: false
           - ruby: 2.5.7
             puppet: 6
             fixtures: .fixtures.yml
             allow_failure: false
-          - ruby: 2.4.9
-            puppet: 5
-            fixtures: .fixtures-latest.yml
-            allow_failure: true
+          - ruby: 2.7.0
+            puppet: 7
+            fixtures: .fixtures.yml
+            allow_failure: false
           - ruby: 2.5.7
             puppet: 6
             fixtures: .fixtures-latest.yml
             allow_failure: true
+          - ruby: 2.7.0
+            puppet: 7
+            fixtures: .fixtures-latest.yml
+            allow_failure: true
     env:
       BUNDLE_WITHOUT: system_tests:release
       PUPPET_GEM_VERSION: "~> ${{ matrix.puppet }}.0"
@@ -61,8 +61,8 @@ jobs:
           - "debian-10"
           - "ubuntu-1804"
         puppet:
-          - "puppet5"
           - "puppet6"
+          - "puppet7"
         keycloak_version:
           - "8.0.1"
           - "12.0.1"
@@ -72,35 +72,35 @@ jobs:
           - "no"
         include:
           - set: "centos-7"
-            puppet: "puppet5"
+            puppet: "puppet6"
             keycloak_version: "8.0.1"
             keycloak_full: "yes"
           - set: "centos-7"
-            puppet: "puppet5"
+            puppet: "puppet6"
             keycloak_version: "12.0.1"
             keycloak_full: "yes"
           - set: "centos-7"
-            puppet: "puppet6"
+            puppet: "puppet7"
             keycloak_version: "8.0.1"
             keycloak_full: "yes"
           - set: "centos-7"
-            puppet: "puppet6"
+            puppet: "puppet7"
             keycloak_version: "12.0.1"
             keycloak_full: "yes"
           - set: "centos-7-domain-mode-cluster"
-            puppet: "puppet5"
+            puppet: "puppet6"
             keycloak_version: "8.0.1"
             keycloak_domain_mode_cluster: "yes"
           - set: "centos-7-domain-mode-cluster"
-            puppet: "puppet5"
+            puppet: "puppet6"
             keycloak_version: "12.0.1"
             keycloak_domain_mode_cluster: "yes"
           - set: "centos-7-domain-mode-cluster"
-            puppet: "puppet6"
+            puppet: "puppet7"
             keycloak_version: "8.0.1"
             keycloak_domain_mode_cluster: "yes"
           - set: "centos-7-domain-mode-cluster"
-            puppet: "puppet6"
+            puppet: "puppet7"
             keycloak_version: "12.0.1"
             keycloak_domain_mode_cluster: "yes"
     env:

diff --git a/.sync.yml b/.sync.yml
@@ -2,14 +2,14 @@
 .github/workflows/ci.yaml:
   unit_name: Puppet ${{ matrix.puppet }} (Ruby ${{ matrix.ruby }} fixtures=${{ matrix.fixtures }})
   unit_includes:
-    - ruby: '2.4.9'
-      puppet: '5'
-      fixtures: .fixtures-latest.yml
-      allow_failure: true
     - ruby: '2.5.7'
       puppet: '6'
       fixtures: .fixtures-latest.yml
       allow_failure: true
+    - ruby: '2.7.0'
+      puppet: '7'
+      fixtures: .fixtures-latest.yml
+      allow_failure: true
   acceptance_name: '${{ matrix.puppet }} ${{ matrix.set }} (keycloak=${{ matrix.keycloak_version }} full=${{ matrix.keycloak_full }})'
   acceptance_matrix:
     set:
@@ -19,44 +19,44 @@
       - debian-10
       - ubuntu-1804
     puppet:
-      - puppet5
       - puppet6
+      - puppet7
     keycloak_version:
       - '8.0.1'
       - '12.0.1'
     keycloak_full: ['no']
     keycloak_domain_mode_cluster: ['no']
   acceptance_includes:
     - set: centos-7
-      puppet: puppet5
+      puppet: puppet6
       keycloak_version: 8.0.1
       keycloak_full: 'yes'
     - set: centos-7
-      puppet: puppet5
+      puppet: puppet6
       keycloak_version: 12.0.1
       keycloak_full: 'yes'
     - set: centos-7
-      puppet: puppet6
+      puppet: puppet7
       keycloak_version: 8.0.1
       keycloak_full: 'yes'
     - set: centos-7
-      puppet: puppet6
+      puppet: puppet7
       keycloak_version: 12.0.1
       keycloak_full: 'yes'
     - set: centos-7-domain-mode-cluster
-      puppet: puppet5
+      puppet: puppet6
       keycloak_version: 8.0.1
       keycloak_domain_mode_cluster: 'yes'
     - set: centos-7-domain-mode-cluster
-      puppet: puppet5
+      puppet: puppet6
       keycloak_version: 12.0.1
       keycloak_domain_mode_cluster: 'yes'
     - set: centos-7-domain-mode-cluster
-      puppet: puppet6
+      puppet: puppet7
       keycloak_version: 8.0.1
       keycloak_domain_mode_cluster: 'yes'
     - set: centos-7-domain-mode-cluster
-      puppet: puppet6
+      puppet: puppet7
       keycloak_version: 12.0.1
       keycloak_domain_mode_cluster: 'yes'
 .gitignore:

diff --git a/manifests/service.pp b/manifests/service.pp
@@ -2,12 +2,9 @@
 class keycloak::service {
   assert_private()
 
-  if $::service_provider == 'systemd' {
-    ::systemd::unit_file { 'keycloak.service':
-      content => template('keycloak/keycloak.service.erb'),
-      notify  => Service['keycloak'],
-    }
-    Exec['systemctl-daemon-reload'] -> Service['keycloak']
+  systemd::unit_file { 'keycloak.service':
+    content => template('keycloak/keycloak.service.erb'),
+    notify  => Service['keycloak'],
   }
 
   service { 'keycloak':

diff --git a/metadata.json b/metadata.json
@@ -84,10 +84,10 @@
   "requirements": [
     {
       "name": "puppet",
-      "version_requirement": ">= 5.0.0 < 7.0.0"
+      "version_requirement": ">= 6.0.0 < 8.0.0"
     }
   ],
   "pdk-version": "1.17.0",
   "template-url": "https://github.com/treydock/pdk-templates.git#master",
-  "template-ref": "heads/master-0-g1f52e6d"
+  "template-ref": "heads/master-0-gc21ae9d"
 }