Avoid errors when prefetching realms (#286)

treydock · Apr 10, 2023 · 978b360 · 978b360
1 parent a6b49ac
commit 978b360
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/puppet/provider/keycloak_api.rb b/lib/puppet/provider/keycloak_api.rb
@@ -116,6 +116,10 @@ def kcadm(*args)
 
   def self.realms
     output = kcadm('get', 'realms', nil, nil, ['realm'])
+  rescue Puppet::ExecutionFailure => e
+    Puppet.notice("Failed to get realms: #{e}")
+    []
+  else
     data = JSON.parse(output)
     data.map { |r| r['realm'] }
   end

diff --git a/lib/puppet/provider/keycloak_realm/kcadm.rb b/lib/puppet/provider/keycloak_realm/kcadm.rb
@@ -103,10 +103,13 @@ def available_flows(realm)
 
   def self.instances
     realms = []
-    output = kcadm('get', 'realms')
-    Puppet.debug("Realms: #{output}")
     begin
+      output = kcadm('get', 'realms')
+      Puppet.debug("Realms: #{output}")
       data = JSON.parse(output)
+    rescue Puppet::ExecutionFailure => e
+      Puppet.notice("Failed to get realms: #{e}")
+      data = []
     rescue JSON::ParserError
       Puppet.debug('Unable to parse output from kcadm get realms')
       data = []