fix behavior of color codes with wrapped cells #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This demonstrates that color codes are ignored for width. It also demonstrates a current bug: that color codes leak from column to column.
If a column contains color codes, we should keep the color contained to the column itself, stopping it at the column boundary and starting it again on the next continuation. This may have a more subtle bug, related to padding between end of data in a column and its boundary, when the color codes have added a background color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a column contains color codes, we should keep the color contained
to the column itself, stopping it at the column boundary and starting
it again on the next continuation.
This may have a more subtle bug, related to padding between end of
data in a column and its boundary, when the color codes have added
a background color.'