feat(message-system): let other-error UI be disabled remotely

trezor · Mar 4, 2025 · eb12b74 · eb12b74
1 parent ab8c71e
commit eb12b74
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/suite/src/reducers/suite/suiteReducer.ts b/packages/suite/src/reducers/suite/suiteReducer.ts
@@ -568,6 +568,13 @@ export const selectFirmwareHashCheckErrorIfEnabled = (state: AppState) => {
         isDebugOnlyHashCheckError(hashCheckError) && !selectIsDebugModeActive(state);
     if (isHiddenBehindDebug) return null;
 
+    if (
+        hashCheckError === 'other-error' &&
+        selectIsFeatureDisabled(state, Feature.firmwareHashCheckOtherError)
+    ) {
+        return null;
+    }
+
     return hashCheckError;
 };
 

diff --git a/suite-common/message-system/src/messageSystemTypes.ts b/suite-common/message-system/src/messageSystemTypes.ts
@@ -17,6 +17,7 @@ export type MessageSystemRootState = {
     messageSystem: MessageSystemState;
 };
 
+// Note: do not rename the feature flag identifiers (otherwise, both old & new would have to be targetted by a message system release)
 export const Feature = {
     coinjoin: 'coinjoin',
     killswitch: 'killswitch',
@@ -35,6 +36,8 @@ export const Feature = {
     firmwareRevisionCheck: 'security.firmware.revisionCheck',
     firmwareRevisionCheckMobile: 'security.firmware.revisionCheck.mobile',
     firmwareHashCheck: 'security.firmware.hashCheck',
+    // subset of `firmwareHashCheck`: can turn off specifically UI for other-error result
+    firmwareHashCheckOtherError: 'security.firmware.hashCheck.otherError',
     entropyCheck: 'security.entropyCheck',
     // FW update feature flag implemented only for mobile app
     firmwareUpdate: 'device.firmware.update',