Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite): fixing too high dragable area over sidebar on mac #17418

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

vojtatranta
Copy link
Contributor

@vojtatranta vojtatranta commented Mar 5, 2025

Description

The first navigation item on Mac OS wasn't clickable due to draggable area overlapping it

Related Issue

Resolve

Screenshots:

Before:

Screen.Recording.2025-03-05.at.12.31.21.mov

Now:

Screen.Recording.2025-03-05.at.2.20.01.PM.mov

Copy link

coderabbitai bot commented Mar 5, 2025

Walkthrough

The update introduces the CSS property -webkit-app-region: no-drag; to the NavigationItemBase styled component. This property is designed to prevent the component from being draggable in environments that support the -webkit-app-region CSS property, such as Electron applications. The change is limited to the styling of the component and does not modify any existing functionality or the declarations of exported or public entities.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1add349 and d9728ab.

📒 Files selected for processing (1)
  • packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/NavigationItem.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/NavigationItem.tsx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: build-web

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vojtatranta vojtatranta self-assigned this Mar 5, 2025
@vojtatranta vojtatranta force-pushed the unclickable-sidebar-nav-button branch from c3ff2e9 to 1add349 Compare March 5, 2025 14:04
@vojtatranta vojtatranta force-pushed the unclickable-sidebar-nav-button branch from 1add349 to d9728ab Compare March 6, 2025 08:37
@jvaclavik jvaclavik merged commit e690769 into develop Mar 6, 2025
28 checks passed
@jvaclavik jvaclavik deleted the unclickable-sidebar-nav-button branch March 6, 2025 08:59
vdovhanych pushed a commit that referenced this pull request Mar 6, 2025
@bosomt
Copy link
Contributor

bosomt commented Mar 8, 2025

QA OK

Info:

  • Suite version: desktop 25.3.1 (f789397)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/25.3.1 Chrome/132.0.6834.194 Electron/34.1.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.9 bitcoin-only (revision null)
  • Transport: BridgeTransport 3.0.0-bundled.25.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants