Improve vite experience

[vojtatranta]

Description

• adds a ESLINT plugin to warn us if our code breask HMR react -refresh (hot modules replacement
• moves cache for viet to the root node_modules, coz other node modules are automatically delete when yarn is run, hence delete build cache

Related Issue

Resolve

Screenshots:

[coderabbitai]

Walkthrough

The changes involve the integration of the eslint-plugin-react-refresh into the project. This includes adding the new dependency to the ESLint package’s package.json file under "devDependencies." The ESLint React configuration is updated to import the new plugin, include its recommended settings, and enforce a new rule for exporting components. Additionally, the Vite configuration for the suite-web package is modified to specify a custom cache directory for build artifacts. Finally, an entry for the new dependency is added to the engagement dependencies list.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac82621 and 56f31d8.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (4)

• packages/eslint/package.json (1 hunks)
• packages/eslint/src/reactConfig.mjs (2 hunks)
• packages/suite-web/vite.config.ts (1 hunks)
• scripts/list-outdated-dependencies/engagement-dependencies.txt (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

• scripts/list-outdated-dependencies/engagement-dependencies.txt
• packages/suite-web/vite.config.ts
• packages/eslint/package.json
• packages/eslint/src/reactConfig.mjs

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: Unit Tests
• GitHub Check: Type Checking
• GitHub Check: Other Checks
• GitHub Check: Releases revision Checks
• GitHub Check: Linting and formatting
• GitHub Check: Build libs for publishing
• GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
• GitHub Check: PR-check / node-override init-api-flaky
• GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
• GitHub Check: build-deploy
• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: test
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: EAS Update

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

🚀 Expo preview is ready!

• Project → trezor-suite-preview
• Platforms → android, ios
• Scheme → trezorsuitelite
• Runtime Version → 26
• More info

Learn more about 𝝠 Expo Github Action

[Lemonexe]

LGTM!
I did notice it was weird that vite created node_modules with only .vite cache in suite-web, but did not have the capacity to think about it deeper 😆

Yes, now the .vite cache is placed correctly, and persists when I install yarn

Lint addition OK, from my experience it doesn't bring very noticeable benefit, but why not. There are now gonna be warnings at every PR.. It'd be great if someone fixed them 😉

[Lemonexe]

oh wait, now I noticed that the ESLint warnings fail the pipeline – we introduced that a few months ago.

No need to fix them at once, just add eslint ignore next line and it can be gradually fixed whenever.
👉 Please consider separating it to another PR, because it's thematically unrelated. So it'd be best to extract the eslint addition to a new branch and finish it there. But it's not the end of the world to do it here in a new commit 🤷