-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(suite): workaround 'loading takes too long' on big accounts by in… #17515
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an emergency improvement this is good.
WalkthroughThe change modifies the timeout value used within the Preloader component. The original static timeout of 90 is replaced by a calculated value of 450, derived from multiplying 90 by 5. This adjustment is made to address delays caused by the initialization actions that incorrectly await altcoin-specific logic, particularly affecting larger accounts. The overall control flow, including the lifecycle status checks for rendering the InitialLoading component, remains unchanged. Furthermore, there are no alterations to any declarations of exported or public entities. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
8488191
to
0d4648c
Compare
0d4648c
to
a1cab72
Compare
https://satoshilabs.slack.com/archives/C06AZUTQMD1/p1741605716469399