chore(tenv): update to image with newest 2.8.9 release emulators #17536
Conversation
WalkthroughThis pull request updates the Docker image tag used for the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docker/docker-compose.suite-dev.yml (1)
7-7: Optional Improvement: Centralize image tag configuration.Since this image tag is updated across multiple Docker Compose files, consider using an environment variable or a shared configuration file (e.g., a
.envfile) to define the image tag. This can improve maintainability and reduce duplication in future updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.github/workflows/test-trezor-user-env-link-e2e.yml(1 hunks)docker/docker-compose.connect-popup-ci.yml(1 hunks)docker/docker-compose.connect-popup-test.yml(1 hunks)docker/docker-compose.connect-test.yml(1 hunks)docker/docker-compose.connect-webextension-test.yml(1 hunks)docker/docker-compose.suite-ci-pw.yml(1 hunks)docker/docker-compose.suite-desktop-ci.yml(1 hunks)docker/docker-compose.suite-dev.yml(1 hunks)docker/docker-compose.suite-native-ci.yml(1 hunks)docker/docker-compose.suite-test.yml(1 hunks)docker/docker-compose.transport-test-ci.yml(1 hunks)submodules/trezor-common(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: PR-check / node-override init-api-flaky
- GitHub Check: PR-check / web-override init-api-flaky
- GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: build-deploy
- GitHub Check: build-deploy
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=passphrase, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
- GitHub Check: transport-e2e-test
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: build-web
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: e2e-test-trezor-user-env-link
🔇 Additional comments (12)
submodules/trezor-common (1)
1-1: Submodule Commit Update VerificationThe submodule commit hash has been updated to
648fff95111282683f25f9beed6308c8b3f712d4, which should align with the new emulator release in the tenv image. Please verify that downstream dependencies and CI pipelines correctly sync with this update..github/workflows/test-trezor-user-env-link-e2e.yml (1)
39-39: Updated Docker image tag in GitHub Actions workflow.The Docker run command now correctly specifies the new image tag
ee7f945dc2cc47e0a5776f3f86dfe5b70455a725, which aligns with the updated emulator release.docker/docker-compose.connect-test.yml (1)
4-4: Updated Docker image tag in Compose configuration.The
trezor-user-env-unixservice now uses the new image tagghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725, ensuring consistency with the newest emulator release.docker/docker-compose.suite-dev.yml (1)
7-7: Consistent image tag update for suite-dev environment.The update to the new image tag ensures that the development setup will run the newest emulator release. Make sure that any dependent configurations or build scripts referencing the old tag are also updated.
docker/docker-compose.suite-native-ci.yml (1)
6-6: Updated Docker image tag for CI configuration.The change to
ghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725ensures that the CI environment now utilizes the latest emulator release.docker/docker-compose.suite-desktop-ci.yml (1)
4-4: Proper image tag update for desktop CI.The
trezor-user-env-unixservice in the desktop CI configuration has been updated to the new image tag, maintaining consistency with other environments. Verify that any related dependencies or service links continue to operate as expected with the updated image.docker/docker-compose.connect-popup-test.yml (1)
4-4: Image Tag Update fortrezor-user-env-unixService
The Docker image tag has been updated toghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725, aligning with the latest release emulators (v2.8.9). This change ensures that the test environment is using the updated image version as intended.docker/docker-compose.suite-ci-pw.yml (1)
4-4: CI Environment Image Update
The image for thetrezor-user-env-unixservice is updated toghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725, ensuring that the CI pipeline leverages the newest emulator release.docker/docker-compose.connect-webextension-test.yml (1)
4-4: WebExtension Test Environment Image Upgrade
The Docker image tag on thetrezor-user-env-unixservice has been updated toghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725. This update ensures that the webextension test runner is operating with the latest emulator environment as specified in the PR objectives.docker/docker-compose.suite-test.yml (1)
3-4: Consistent Environment Configuration Update
Thetrezor-user-env-unixservice image has been updated to the new tagghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725. This ensures uniformity across the suite test environment by using the latest emulator release.docker/docker-compose.transport-test-ci.yml (1)
3-4: Transport Test CI Image Tag Upgrade
The image for thetrezor-user-env-unixservice in the transport test CI configuration is now updated toghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725. Please verify that the updated image is fully compatible with your CI tests and local development needs.docker/docker-compose.connect-popup-ci.yml (1)
4-4: Review: Updated Docker Image TagThe new image tag:
ghcr.io/trezor/trezor-user-env:ee7f945dc2cc47e0a5776f3f86dfe5b70455a725correctly reflects the updated 2.8.9 release emulators as outlined in the PR objectives. This change ensures that the service
trezor-user-env-unixin this CI configuration uses the latest image. Please double-check that similar updates across other relevant Docker Compose files are consistent with this change.
New release emulators in tenv