Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): reintroduce FW update banner on dashboard #17538

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Nodonisko
Copy link
Contributor

Description

Related Issue

Resolve

Screenshots:

@Nodonisko Nodonisko requested a review from a team as a code owner March 10, 2025 15:57
Copy link

coderabbitai bot commented Mar 10, 2025

Walkthrough

The changes integrate a new FirmwareUpdateAlert component within the portfolio display. In the PortfolioContent file, an import statement for FirmwareUpdateAlert is added and the component is rendered immediately before the AnimatedVStack component in the return block. This update positions the firmware update notification above the portfolio graph and transfer buttons, with no additional modifications to the logic, error handling, or control flow within the component.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb2159 and 3ed242a.

📒 Files selected for processing (1)
  • suite-native/module-home/src/screens/HomeScreen/components/PortfolioContent.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: EAS Update
  • GitHub Check: prepare_android_test_app
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Setup and Cache Dependencies
🔇 Additional comments (2)
suite-native/module-home/src/screens/HomeScreen/components/PortfolioContent.tsx (2)

21-21: Import looks good.

The import statement for the FirmwareUpdateAlert component follows the file's import organization pattern, with component-specific imports at the bottom of the import section.


52-53:

✅ Verification successful

Good placement for the alert component.

The FirmwareUpdateAlert component is appropriately placed at the top of the main VStack, which is a logical position for an alert that should be prominently visible. The blank line after the component improves code readability.

I notice that the component is rendered unconditionally without any props. This suggests that the component handles its own visibility logic internally. If this is a reintroduction of a previous feature, this approach is likely consistent with the prior implementation.


🏁 Script executed:

#!/bin/bash
# Check if the FirmwareUpdateAlert component handles its own visibility
ast-grep --pattern 'function FirmwareUpdateAlert' -A 20

Length of output: 57


Manual Verification Needed for FirmwareUpdateAlert Definition

The placement of <FirmwareUpdateAlert /> at the top of the main VStack remains well justified for prominent visibility. However, since the initial search (using the function keyword) did not yield any results, it’s necessary to verify whether the component is defined using an alternative pattern (e.g., an arrow function or an exported function declaration). Please run the above script to confirm that FirmwareUpdateAlert indeed encapsulates its internal visibility logic.


🏁 Script executed:

#!/bin/bash
# Search for FirmwareUpdateAlert defined as an arrow function or exported function in the repository
rg "const FirmwareUpdateAlert\s*=" -n -A 20
rg "export function FirmwareUpdateAlert" -n -A 20

Length of output: 3093


FirmwareUpdateAlert Component Verification

  • The placement of <FirmwareUpdateAlert /> at the top of the main VStack is ideal for prominently displaying alerts.
  • The component is defined in suite-native/module-home/src/screens/HomeScreen/components/FirmwareUpdateAlert.tsx as an arrow function and leverages internal hooks (like useSelector) to manage its own visibility logic.
  • Rendering the component unconditionally without props is consistent with prior implementations, as it encapsulates all necessary logic internally.

Overall, the code changes are in line with the intended design.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 To do
Development

Successfully merging this pull request may close these issues.

2 participants