bzip2.rs: improve test coverage
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
bzip2-test-coverage
branch
7 times, most recently
from
8ad5cc5
to
77f0f9c
Compare
Codecov ReportAttention: Patch coverage is
|
folkertdev
force-pushed
the
bzip2-test-coverage
branch
from
77f0f9c
to
76e6ab6
Compare
folkertdev
commented
Nov 11, 2024
tests/quick.rs
Outdated
Comment on lines
76
to
125
| #[cfg(unix)] | ||
| unsafe fn custom_tty() -> ( | ||
| std::sync::MutexGuard<'static, ()>, | ||
| std::process::Stdio, | ||
| std::process::Stdio, | ||
| ) { | ||
| use std::{os::fd::FromRawFd, sync::Mutex}; | ||
|
|
||
| // only one thread should be doing this at a time | ||
| static X: Mutex<()> = Mutex::new(()); | ||
|
|
||
| let guard = X.lock().unwrap(); | ||
|
|
||
| // Open the master PTY using libc | ||
| let cstring = std::ffi::CString::new("/dev/ptmx").unwrap(); | ||
| let master_fd = unsafe { libc::open(cstring.as_ptr(), libc::O_RDWR) }; | ||
| if master_fd < 0 { | ||
| panic!("{}", std::io::Error::last_os_error()); | ||
| } | ||
|
|
||
| // Grant access to the slave PTY | ||
| if unsafe { libc::grantpt(master_fd) } < 0 { | ||
| panic!("{}", std::io::Error::last_os_error()); | ||
| } | ||
|
|
||
| // Unlock the slave PTY | ||
| if unsafe { libc::unlockpt(master_fd) } < 0 { | ||
| panic!("{}", std::io::Error::last_os_error()); | ||
| } | ||
|
|
||
| // Get the path to the slave PTY | ||
| let slave_path_ptr = unsafe { libc::ptsname(master_fd) }; | ||
| if slave_path_ptr.is_null() { | ||
| panic!("{}", std::io::Error::last_os_error()); | ||
| } | ||
|
|
||
| // Open the slave PTY | ||
| let slave_fd = unsafe { libc::open(slave_path_ptr, libc::O_RDWR) }; | ||
| if slave_fd < 0 { | ||
| panic!("{}", std::io::Error::last_os_error()); | ||
| } | ||
|
|
||
| unsafe { | ||
| ( | ||
| guard, | ||
| Stdio::from_raw_fd(master_fd), | ||
| Stdio::from_raw_fd(slave_fd), | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
the internet told me this is how to set up a TTY. it appears to work well as a stdout device, but not for stdin. It does work locally but that might be because of my shell? anyway on CI it does not work.
There was a problem hiding this comment.
I've removed the TTY stuff for now, the other changes are more important
folkertdev
force-pushed
the
bzip2-test-coverage
branch
from
76e6ab6
to
d6b2008
Compare
folkertdev
force-pushed
the
bzip2-test-coverage
branch
from
d6b2008
to
13b82f2
Compare
bjorn3
reviewed
Nov 12, 2024
Co-authored-by: bjorn3 <[email protected]>
bjorn3
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves the tests around, and adds some additional coverage.
Codecov is not happy, but actuall if you look at it it's fine (the "uncovered lines" are comments...)