fix for reading/writing uninitialized memory #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
window-uninitialized-memory
branch
2 times, most recently
from
02cec74
to
34af1d3
Compare
folkertdev
force-pushed
the
window-uninitialized-memory
branch
from
34af1d3
to
1162053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues were in unreleased code, so there is not much of a risk here. Glad we caught it though.
I've also fixed the rest of the
test-libz-rs-systests so that they can run under miri. I'll add some CI infra for that in a followup (probably requires some fighting with github CI).cc @inahga