Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "load the inflate reader and writer to the stack" #252

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

folkertdev
Copy link
Collaborator

This reverts commit c264893.

It turns out that loading the reader and writer to the stack is not beneficial in general:

zlib-rs performance 0 3 0 - 0 4 0

that jump in runtime for chunk size = 7 is the reverted commit.

Loading to the stack does help, but we need to be more specific when we do it.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 95.72650% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
zlib-rs/src/inflate.rs 95.72% 5 Missing ⚠️
Files with missing lines Coverage Δ
zlib-rs/src/inflate.rs 95.31% <95.72%> (-0.13%) ⬇️

... and 39 files with indirect coverage changes

@folkertdev folkertdev merged commit afa1b5b into main Nov 18, 2024
19 checks passed
@folkertdev folkertdev deleted the revert-loading-to-stack branch November 18, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants