Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gzip support for inflate #33

Merged
merged 49 commits into from
Feb 21, 2024
Merged

Gzip support for inflate #33

merged 49 commits into from
Feb 21, 2024

Conversation

bramtweedegolf
Copy link
Collaborator

Partial gzip implementation for inflate

@bramtweedegolf bramtweedegolf changed the title Gzip inflate Gzip support for inflate Feb 19, 2024
folkertdev
folkertdev reviewed Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass

zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
folkertdev
folkertdev reviewed Feb 19, 2024
View reviewed changes
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (0f6a4bc) 85.96% compared to head (e8d815d) 86.78%.

Files Patch % Lines
zlib-rs/src/inflate.rs 92.85% 19 Missing ⚠️
zlib-rs/src/deflate.rs 96.62% 5 Missing ⚠️
libz-rs-sys/src/lib.rs 75.00% 2 Missing ⚠️
load-dynamic-libz-ng/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   85.96%   86.78%   +0.81%     
==========================================
  Files          31       31              
  Lines        7503     7929     +426     
==========================================
+ Hits         6450     6881     +431     
+ Misses       1053     1048       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

folkertdev
folkertdev reviewed Feb 19, 2024
View reviewed changes
zlib-rs/src/c_api.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
@bramtweedegolf bramtweedegolf marked this pull request as ready for review February 20, 2024 08:26
folkertdev
folkertdev reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also apply cargo fmt

libz-rs-sys/src/tests/inflate.rs Outdated Show resolved Hide resolved
libz-rs-sys/src/tests/inflate.rs Outdated Show resolved Hide resolved
libz-rs-sys/src/lib.rs Outdated Show resolved Hide resolved
zlib-rs/src/c_api.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
zlib-rs/src/inflate.rs Outdated Show resolved Hide resolved
bramtweedegolf and others added 24 commits February 20, 2024 10:22
@bramtweedegolf
Merge branch 'main' of github.com:memorysafety/zlib-rs into gzip-inflate
b8ff9e9
@bramtweedegolf
Fixed small issues and formatting
7450ff9
@bramtweedegolf
Merge
38a1acc
@bramtweedegolf
Merge branch 'main' of github.com:memorysafety/zlib-rs into gzip-inflate
f1aeb67
@bramtweedegolf
Small fixes, merge
36c75e2
@folkertdev
copy the state.head field, safely
c700c6d
@folkertdev
prevent a dangling pointer in tests
7315cea
@folkertdev
fix potential overflow in gzip header code
1bdc318
@folkertdev
cleanup
ee56ea3
@folkertdev
remove unsafety
f84f162
@folkertdev
sanity test: crc of no input is the start crc
cd09821
@folkertdev
fix bug in name/comment decode
4aa60dc
@folkertdev
fix stored block not updating the crc checksum
5caaf65
@folkertdev
enable the fuzzer for gzip
4af011e
@folkertdev
test basic gzip header inflate
1b26048
@folkertdev
fix bug in inflateGetHeader
ed9f429
@folkertdev
more interesting gzip test
0bde1be
@folkertdev
fix alignment bug in crc32
5117a6a
@folkertdev
self.in_available is out of date
5fa94da
@folkertdev
Merge remote-tracking branch 'origin/main' into gzip-inflate
02ca800
@folkertdev
read name/comment even if there is no space for the comment
3291499
@folkertdev
always read the name/comment, even if there is no space
f530986
@folkertdev
an attempt to clean up the extra field logic
fa3d8f2
@folkertdev
clippy
e8d815d
@folkertdev folkertdev merged commit 336b6d4 into main Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bramtweedegolf @folkertdev