Safe window #7

folkertdev · 2024-01-16T20:10:18Z

make the Window into a safe abstraction

That leaves 2 unsafe things to be fixed currently

state.pending and state.sym_buf sharing memory. We turn sym_buf into a mutable slice which is unsound because the memory can be written to by state.pending
there is some raw pointer arithmetic in longest_match that I don't understand well yet.

folkertdev added 30 commits January 15, 2024 21:17

memcpy -> copy_nonoverlapping

a57d355

save one instruction in hashing

76c33fd

use Ord::min

c52bc07

extract heap helper function

38c3d72

prepare hashcalc for window as slice

0acb245

first tiny step: use as_ptr_mut()

5ba6c5e

fix bug in medium compression

5d76285

update filled when reading more input

47722fa

improve fuzzing setup

5519d75

fix bug in medium compression fizzle

b3af847

testing for bug in fizzle

cd30d61

make medium safe

e91ac49

centralize testing/fuzzing helpers

c9ee09d

make rle safe

1525d10

make quick safe

af6b11e

make fast safe

616cf1f

make slow safe

b5f150e

first pass at longest_match safe

8b4c4f4

remove unused function

d5c8fc6

make hash_calc safe

5a2961a

more safety

16a4826

move high_water stuff into Window

9800451

cleanup

8d6d1c4

clippy

6ef34a8

give deflate window its own file

9b21752

give pending its own file

a783cb2

forbid unsafe in a bunch of places

6421c19

clippy

d7d3cc9

fix logic error in initializing window

5040fc0

make sure inflate buffer is big enough

6e58f83

folkertdev merged commit 7d8b972 into main Jan 16, 2024
5 checks passed

Provide feedback