Amesos2 : add an option to gather/scatter vectors #13832
Merged
+1,089
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: iyamazaki |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
There was a problem hiding this comment.
@iyamazaki, would it be possible to add some basic unit tests for this new function in Teuchos? We don't want code in a package to only be tested in downstream packages. We want code to be tested pretty well in native package tests.
| @@ -254,6 +254,27 @@ scatter (const Packet sendBuf[], | |||
| "See Bug 6375 and Bug 6336."); | |||
| } | |||
|
|
|||
| template<typename Ordinal, typename Packet> | |||
| void | |||
| scatterv (const Packet sendBuf[], | |||
There was a problem hiding this comment.
There should be some basic native Teuchos unit test for this function. We don't want code that is only tested in downstream packages.
There was a problem hiding this comment.
Thank you, @bartlettroscoe. We'll add a unit test to Teuchos.
There was a problem hiding this comment.
@bartlettroscoe. We added a unit test for scaterv, but I have also noticed the following lines for scatter:
Trilinos/packages/teuchos/comm/src/Teuchos_CommHelpers.hpp
Lines 249 to 254 in 74d6091
Do you know what these bugs refer to?
There was a problem hiding this comment.
@iyamazaki, those must be bugs from the old Bugzilla site for Trilinos, before Trilinos moved to GitHub (back on 2009?).
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: iyamazaki |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Signed-off-by: iyamazaki <[email protected]>
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: iyamazaki |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Signed-off-by: iyamazaki <[email protected]>
iyamazaki
force-pushed
the
amesos2-gather-vec
branch
from
6823b2a to
5ddc727
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: iyamazaki |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Signed-off-by: iyamazaki <[email protected]>
Signed-off-by: iyamazaki <[email protected]>
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: iyamazaki |
bartlettroscoe
previously approved these changes
Mar 1, 2025
Comment on lines
185
to
187
| // | ||
| // mfh 14 Jul 2015: We only need to test int for now. See Bug 6375. | ||
| // |
Comment on lines
44
to
47
| const MpiComm<int>* mpiComm = dynamic_cast<const MpiComm<int>* > (&comm); | ||
| TEUCHOS_TEST_FOR_EXCEPTION | ||
| (mpiComm == NULL, std::logic_error, "Building with MPI, but default " | ||
| "communicator is not a Teuchos::MpiComm!"); |
There was a problem hiding this comment.
Suggested change
| const MpiComm<int>* mpiComm = dynamic_cast<const MpiComm<int>* > (&comm); | |
| TEUCHOS_TEST_FOR_EXCEPTION | |
| (mpiComm == NULL, std::logic_error, "Building with MPI, but default " | |
| "communicator is not a Teuchos::MpiComm!"); | |
| const MpiComm<int>& mpiComm = Teuchos::dyn_cast<const MpiComm<int>> (comm); |
Might using dyn_cast<>()?
| TEUCHOS_TEST_FOR_EXCEPTION | ||
| (mpiComm == NULL, std::logic_error, "Building with MPI, but default " | ||
| "communicator is not a Teuchos::MpiComm!"); | ||
| MPI_Comm rawMpiComm = * (mpiComm->getRawMpiComm ()); |
There was a problem hiding this comment.
Suggested change
| MPI_Comm rawMpiComm = * (mpiComm->getRawMpiComm ()); | |
| MPI_Comm rawMpiComm = *(mpiComm.getRawMpiComm()); |
As per above.
| @@ -254,6 +254,27 @@ scatter (const Packet sendBuf[], | |||
| "See Bug 6375 and Bug 6336."); | |||
| } | |||
|
|
|||
| template<typename Ordinal, typename Packet> | |||
| void | |||
| scatterv (const Packet sendBuf[], | |||
There was a problem hiding this comment.
@iyamazaki, those must be bugs from the old Bugzilla site for Trilinos, before Trilinos moved to GitHub (back on 2009?).
Comment on lines
+133
to
+136
| // Don't trust that any other Teuchos communicator wrapper functions | ||
| // work here. Instead, if building with MPI, use raw MPI. If not | ||
| // building with MPI, first test that comm has only one process, | ||
| // then assume this in the test. |
There was a problem hiding this comment.
Reasonable to not trust Teuchos wrapper functions as the final test pass/fail.
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Signed-off-by: iyamazaki <[email protected]>
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: iyamazaki |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
ndellingwood
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
We discussed the amesos2 changes, look reasonable, thanks @iyamazaki
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/amesos2
Motivation
This PR adds an option to gather/scatter vectors using
teuchos.Testing
Additional Information
amesos2parameter to turn on/off this option (default is on)