Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering queries by client tags in the Web UI #24494

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Nazarii
Copy link
Member

@Nazarii Nazarii commented Dec 16, 2024

Description

Currently it is not possible to filter out queries in the Web UI by the client tags values which becomes annoying to find specific queries when there are 30 of them running in parallel. This change adds support to filter queries by client tags in Web UI by modifying the api/query endpoint response to include additional value and adapting the UI part to do filtering.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text:
Add support for filtering by query client tags in the Web UI.

Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the ui Web UI label Dec 16, 2024
Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Nazarii Nazarii changed the title Add support for filtering by client tags in Web UI Add support for filtering queries by client tags in Web UI Dec 16, 2024
@Nazarii Nazarii changed the title Add support for filtering queries by client tags in Web UI Add support for filtering queries by client tags in the Web UI Dec 16, 2024
@Nazarii Nazarii force-pushed the client-tags-filtering branch from b9830ec to 543b1fa Compare December 16, 2024 23:08
Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr requested a review from wendigo December 17, 2024 01:10
Copy link

cla-bot bot commented Jan 7, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Nazarii Nazarii force-pushed the client-tags-filtering branch from 4fed010 to 543b1fa Compare January 7, 2025 09:35
Copy link

cla-bot bot commented Jan 7, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Nazarii Nazarii force-pushed the client-tags-filtering branch from 543b1fa to 0b68e47 Compare January 7, 2025 09:38
Copy link

cla-bot bot commented Jan 7, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Nazarii Nazarii force-pushed the client-tags-filtering branch from 0b68e47 to 15afbe7 Compare January 10, 2025 15:30
@cla-bot cla-bot bot added the cla-signed label Jan 10, 2025
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screenshot of what the web ui looks like before and after this change ?

@Nazarii
Copy link
Member Author

Nazarii commented Jan 14, 2025

Can you add a screenshot of what the web ui looks like before and after this change ?

Before:
Screenshot 2025-01-14 at 15 50 33
After:
Screenshot 2025-01-14 at 15 51 05

@Nazarii Nazarii force-pushed the client-tags-filtering branch from 15afbe7 to 99d4cbc Compare January 14, 2025 16:23
@Nazarii Nazarii force-pushed the client-tags-filtering branch from 99d4cbc to d979f84 Compare January 14, 2025 19:01
@wendigo
Copy link
Contributor

wendigo commented Jan 14, 2025

[INFO] [warn] components/QueryList.jsx
[INFO] [warn] Code style issues found in the above file. Run Prettier with --write to fix.

@Nazarii Nazarii force-pushed the client-tags-filtering branch from d979f84 to 6e4799a Compare January 14, 2025 20:40
@Nazarii
Copy link
Member Author

Nazarii commented Jan 14, 2025

[INFO] [warn] components/QueryList.jsx
[INFO] [warn] Code style issues found in the above file. Run Prettier with --write to fix.

Addressed.

@raunaqmorarka raunaqmorarka merged commit 13e51e1 into trinodb:master Jan 15, 2025
92 of 94 checks passed
@github-actions github-actions bot added this to the 469 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants