Fix failure when equality delete updated nested fields in Iceberg #24512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-nested-field
branch
2 times, most recently
from
73516cb to
ff29353
Compare
ebyhr
force-pushed
the
ebi/iceberg-nested-field
branch
from
ff29353 to
15f60de
Compare
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSource.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/delete/RowPredicate.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-nested-field
branch
from
15f60de to
1757e4d
Compare
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/delete/RowPredicate.java
Outdated
Show resolved
Hide resolved
| { | ||
| int positionCount = page.getPositionCount(); | ||
| int[] retained = new int[positionCount]; | ||
| int retainedCount = 0; | ||
| for (int position = 0; position < positionCount; position++) { | ||
| if (test(page, position)) { | ||
| Page selectedPage = columns.length == 0 ? page : page.getColumns(columns); | ||
| if (test(selectedPage, position)) { |
There was a problem hiding this comment.
If we extract a subset of columns as input to test, then does it break assumptions about block index in the implementations ? E.g. in io.trino.plugin.iceberg.delete.PositionDeleteFilter#createPredicate we have page.getBlock(filePosChannel) and that can select different column if we pass in a subset of blocks of the page.
There was a problem hiding this comment.
I'm not sure if I fully understand your concern. List<IcebergColumnHandle> columns argument in PositionDeleteFilter#createPredicate is also adjusted in this PR. https://github.com/trinodb/trino/pull/24512/files#diff-705548e3717786bbc076aba181f1eca081ec69200050c18100bfa959e05095dfR357
ebyhr
force-pushed
the
ebi/iceberg-nested-field
branch
from
1757e4d to
b567ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18625
Release notes