Configure Phoenix server scan page timeout

[virajjasani]

Description

Phoenix provides a way to configure Page size while creating JDBC Connection. Page size in Phoenix is important aspect to control how much work a single HBase RPC handler should perform before timing out. When the given RPC thread times out based on the page size, Phoenix client retrieves dummy result from the server and resume the operation by sending another RPC request, until eventually the result iteration is completed.

As Phoenix supports both OLTP and OLAP workloads, setting the page size timeout is crucial to manage HBase server resources efficiently. While by default, Phoenix client relies on HBase RPC timeout values to derive Page size, using Configuration property is flexible and efficient way for the clients to have better control.

Additional context and related issues

Release notes

## Phoenix
* Allow configuring scan page timeout with the `phoenix.server-scan-page-timeout` configuration property. ({issue}`24689`)

[ebyhr]

I'm not sure if we really need this property or not. Can't we set this property via phoenix.connection-url or phoenix.config.resources?

[virajjasani]

I'm not sure if we really need this property or not. Can't we set this property via phoenix.connection-url or phoenix.config.resources?

Unfortunately, neither of them covers it. For instance, phoenix.config.resources can cover generic HBase RPC timeout config but that will be applicable to all Scanners. Using Connection props is the only way to ensure a given use case (specifically OLAP) can use fine tuned timeout so that other latency sensitive requests don't have to wait for too long.

[ebyhr]

@virajjasani The answer doesn't explain why phoenix.connection-url doesn't work. Most JDBC drivers allow setting properties by appending key-value in the URL. Could you explain why it doesn't work in Phoenix JDBC driver?

[virajjasani]

Since the early days, very limited properties have been allowed in the url:

• AutoCommit
• TenantId
• CurrentSCN
• BuildIndexAt
• UpsertBatchSize
• UpsertBatchSizeBytes
• Consistency
• RequestMetric
• schema

These are simple property names (when compared with phoenix.server.page.size.ms and many others). I am not aware whether simplicity is the reason or whether the fact that the above listed properties are the most fundamental ones is the reason behind allowing to derive only these properties from the url whereas the remaining ones are expected to be provided with Properties object.

[virajjasani]

I also see that we are using this in test setup but it is of no use because the real value of namespace mapping is coming from elsewhere, using it in url has no impact:

    public String getJdbcUrl()
    {
        return format("jdbc:phoenix:localhost:%d:/hbase;phoenix.schema.isNamespaceMappingEnabled=true", port);
    }

There is different story for isNamespaceMappingEnabled though and I would like to fix (remove) it in separate PR. It is sort of not so useful property anymore.

[ebyhr]

@virajjasani Please avoid doing force-push with rebase as much as possible. It's hard to understand the diff since the last review on GitHub UI.