Fixing ordering of GamePlayer in sidePanel

[RenXFlo]

Fixed ordering for EconomyPanels in game (tested on 3 maps TWW included)

[CLAassistant]

All committers have signed the CLA.

[RenXFlo]

@frigoref could you look at this pull request and give me feedback

[frigoref]

Thanks for the PR!
Have a look for the comments. You can close the one where nothing is to be done (PlayerOrder) and leave the other one (PlayerOrderComparator) to @DanVanAtta.

[frigoref]

1. Method iterator: Forcing the iterator to work on the sorted list is likely an overkill.
2. Method stream: Did you check that it compiles afterwards? For me I get for example:
   triplea\game-app\game-core\src\main\java\games\strategy\triplea\attachments\AbstractConditionsAttachment.java:74: error: stream() has private access in PlayerList getData().getPlayerList().stream()

[RenXFlo]

1. Method iterator: Forcing the iterator to work on the sorted list is likely an overkill.
2. Method stream: Did you check that it compiles afterwards? For me I get for example:
   triplea\game-app\game-core\src\main\java\games\strategy\triplea\attachments\AbstractConditionsAttachment.java:74: error: stream() has private access in PlayerList getData().getPlayerList().stream()

1. I'll revert the change.
2. Checked it didnt work afther I played with it and forgot to change it back. I'll change it in next commit.

[frigoref]

Forcing method currentPlayers to work on the sorted list is likely an overkill. We only want it for the UI.

[RenXFlo]

Forcing method currentPlayers to work on the sorted list is likely an overkill. We only want it for the UI.

I'll revert the change.

[frigoref]

Probably something for another fix, but the methods GameStep.isXxxStep all work on the game step name while their method names ...Step refer to the GameStep object. Hence, either the methods should be rename to something like ...StepName and/or the parameters passed should be rather of type GameStep.
Also, it seems odd to me to have null a a step name.
@DanVanAtta: Can you explain why/if this is really needed?

[frigoref]

@RenXFlo Did you check whether the ordering is still fixed?

[RenXFlo]

@RenXFlo Did you check whether the ordering is still fixed?

@frigoref It is on my side aam I some anomaly ? Does it not work for you ?

[frigoref]

@RenXFlo Did you check whether the ordering is still fixed?

@frigoref It is on my side aam I some anomaly ? Does it not work for you ?

@RenXFlo No, but I haven't tested it. So I wanted to confirm that after the changes done it is still giving the result from the screenshot of your initial post in this thread.
When you confirm this I would merge the PR.

[RenXFlo]

@frigoref Yes it still does work as shown in the image.