fix test

trocco-io · Apr 1, 2024 · 13f04ba · 13f04ba
1 parent 7b85649
commit 13f04ba
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 23 deletions.
diff --git a/src/test/java/org/embulk/output/databricks/TestDatabricksOutputPlugin.java b/src/test/java/org/embulk/output/databricks/TestDatabricksOutputPlugin.java
@@ -28,11 +28,17 @@ public class TestDatabricksOutputPlugin {
 
   @Before
   public void setup() {
+    if (ConfigUtil.disableOnlineTest()) {
+      return;
+    }
     ConnectionUtil.dropAllTemporaryTables();
   }
 
   @After
   public void cleanup() {
+    if (ConfigUtil.disableOnlineTest()) {
+      return;
+    }
     ConnectionUtil.dropAllTemporaryTables();
   }
 

diff --git a/src/test/java/org/embulk/output/databricks/util/ConfigUtil.java b/src/test/java/org/embulk/output/databricks/util/ConfigUtil.java
@@ -1,5 +1,7 @@
 package org.embulk.output.databricks.util;
 
+import static com.google.common.base.Strings.isNullOrEmpty;
+
 import org.embulk.config.ConfigSource;
 import org.embulk.output.DatabricksOutputPlugin;
 import org.embulk.output.jdbc.AbstractJdbcOutputPlugin;
@@ -18,8 +20,14 @@ public class ConfigUtil {
           .build();
   private static final ConfigMapper CONFIG_MAPPER = CONFIG_MAPPER_FACTORY.createConfigMapper();
 
+  private static final String configEnvName = "EMBULK_OUTPUT_DATABRICKS_TEST_CONFIG";
+
+  public static Boolean disableOnlineTest() {
+    return isNullOrEmpty(System.getenv(configEnvName));
+  }
+
   public static ConfigSource baseConfigSource() {
-    return EmbulkTests.config("EMBULK_OUTPUT_DATABRICKS_TEST_CONFIG");
+    return EmbulkTests.config(configEnvName);
   }
 
   public interface TestTask extends Task {

diff --git a/src/test/java/org/embulk/output/snowflake/TestingEmbulkHack.java b/src/test/java/org/embulk/output/snowflake/TestingEmbulkHack.java