Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mealie to community train #1701

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Add mealie to community train #1701

merged 12 commits into from
Nov 14, 2023

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Nov 3, 2023

@stavros-k stavros-k added the WIP Work In Progress label Nov 3, 2023
@stavros-k stavros-k self-assigned this Nov 3, 2023
@stavros-k stavros-k changed the base branch from master to storage-template-shim November 3, 2023 17:38
@stavros-k stavros-k force-pushed the mealie branch 2 times, most recently from 7749e5f to a305fc9 Compare November 6, 2023 16:24
@stavros-k stavros-k force-pushed the storage-template-shim branch from d060c0f to 5e8e793 Compare November 6, 2023 16:25
@stavros-k stavros-k force-pushed the mealie branch 3 times, most recently from 195cc03 to f345238 Compare November 6, 2023 17:26
@stavros-k stavros-k force-pushed the storage-template-shim branch from f5f4390 to 4fa8f75 Compare November 7, 2023 14:29
@stavros-k stavros-k force-pushed the storage-template-shim branch from 4fa8f75 to 16a2da8 Compare November 8, 2023 18:10
@stavros-k stavros-k removed the WIP Work In Progress label Nov 8, 2023
@stavros-k stavros-k marked this pull request as ready for review November 8, 2023 18:34
@stavros-k stavros-k requested review from Qubad786 and sonicaj November 8, 2023 18:36

def newer_mapping(image_tags):
key = list(image_tags.keys())[0]
tags = {t.strip('v'): t for t in image_tags[key] if RE_STABLE_VERSION.fullmatch(t)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doubtful this will work..it will work similarly with v1.0.0-RC1.1 and v1.0.0-BETA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan is to only automatically upgrade to the next "stable" release.
RC versions don't have a specific format, so we can't really account for that.
I'm hoping that there won't be another RC release upstream, but if it does we can upgrade that one manual once.

@stavros-k stavros-k force-pushed the storage-template-shim branch from 9545c63 to 9d32f5f Compare November 14, 2023 13:56
Base automatically changed from storage-template-shim to master November 14, 2023 20:45
@stavros-k stavros-k merged commit 87f5339 into master Nov 14, 2023
@stavros-k stavros-k deleted the mealie branch November 14, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Chart Suggestion: Mealie
2 participants