-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131090 / 25.04 / Fibre Channel Support #14683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeagherix
changed the title
NAS-131090 / 25.04 / NAS-131090
NAS-131090 / 25.04 / Fibre Channel Support
Oct 14, 2024
bmeagherix
force-pushed
the
NAS-131090
branch
2 times, most recently
from
October 21, 2024 18:01
e299d4c
to
474c7c0
Compare
anodos325
reviewed
Oct 21, 2024
bmeagherix
force-pushed
the
NAS-131090
branch
from
October 21, 2024 20:46
a28585b
to
5ff516b
Compare
bmeagherix
force-pushed
the
NAS-131090
branch
from
October 24, 2024 22:50
66b9758
to
959eebc
Compare
anodos325
reviewed
Oct 25, 2024
anodos325
reviewed
Oct 25, 2024
anodos325
reviewed
Oct 25, 2024
anodos325
reviewed
Oct 25, 2024
anodos325
reviewed
Oct 25, 2024
anodos325
reviewed
Oct 25, 2024
FWIW, currently writing more unit tests, but will need to wait for another PR to land/merge before rebasing this PR and committing those tests. |
bmeagherix
force-pushed
the
NAS-131090
branch
from
October 28, 2024 18:13
fd2eba7
to
5faa8c2
Compare
anodos325
approved these changes
Oct 29, 2024
bmeagherix
force-pushed
the
NAS-131090
branch
from
October 29, 2024 18:38
7daf46b
to
54dac2d
Compare
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Fibre Channel targets
Overview
SCST includes support for Fibre Channel targets using QLA2xxx HBAs. This PR includes the middleware changes necessary to utilize the mechanism.
API summary
In CORE an
fcport
CRUD interface was available to perform the target to FC port mapping. A similar CRUD API is presented here.However, in CORE we could reliably pair the ports on each node in a HA system simply by using the same moniker (e.g.
isp0
). Since this is not quite true in SCALE we instead will have a DB table / API to wire the ports together based upon the slot information obtained fromdmidecode
. The auto-wiring will use a default moniker offc0
, etc ... so that any migration from SCALE will be forced to manually check that the A/B controllers port pairing are as expected. The upshot of all of this is that another (private)fc.fc_host
API is implemented.The
fc.fc_host
API will also include the NPIV setting for the FC Host port, which in CORE was aSystem Tunable
.To support the UI
fcport.port_choices
andfcport.status
are also included.This CI run shows