NAS-132001 / 25.04 / Fix __job_by_credential_and_id crashing for non-full-admins and internally ran jobs
#14790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernally ran jobs
bugclerk
changed the title
__job_by_credential_and_id crashing for non-full-admins and internally ran jobs__job_by_credential_and_id crashing for non-full-admins and internally ran jobs
|
time 1:30 |
|
@themylogin we missed the 24.10.0 boat. It's too late now. Not sure if you want to keep this ticket opened up or close it and push a new PR with what you described in the other PR? |
|
@yocalebo we should merge it, this should still be fixed. The PR I opened is a separate issue. |
yocalebo
approved these changes
Oct 28, 2024
|
retest this please |
anodos325
reviewed
Oct 29, 2024
| @@ -101,6 +101,11 @@ def __job_by_credential_and_id(self, credential, job_id): | |||
|
|
|||
| job = self.middleware.jobs[job_id] | |||
|
|
|||
| if job.credentials is None: | |||
| raise CallError( | |||
| 'Only users with full administrative privileges can download internal job logs', errno.EPERM, | |||
There was a problem hiding this comment.
Can't someone hit this by running core.job_wait for any job that's owned by root?
There was a problem hiding this comment.
You are correct. Fixed the error message.
anodos325
approved these changes
Oct 29, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yocalebo please note that this only fixes half of the real issue. I created a new ticket for you to review and determine fix version https://ixsystems.atlassian.net/browse/NAS-132031