NAS-131665 / 25.04 / Convert NFS config to new api. #15336
Merged
+434
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
reviewed
Jan 10, 2025
anodos325
approved these changes
Jan 13, 2025
creatorcary
requested changes
Jan 13, 2025
bmeagherix
requested changes
Jan 13, 2025
creatorcary
reviewed
Jan 13, 2025
Added a common 'TcpPort' type. Fix tcp port exclude option. Convert bindip_choices to new api. Convert NFS share CRUD to new api. Adds a new pydantic type: Dir Remove blocking calls in schema. Fixup remaining bits. Add None as option for locked. Address comments
bmeagherix
approved these changes
Jan 14, 2025
yocalebo
requested changes
Jan 14, 2025
Add nfs validators module to plugins/nfs_. Update CI tests.
creatorcary
approved these changes
Jan 15, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert NFS config to new api.
Added a common 'TcpPort' type.
Addressed additional comments. Moved all field_validator tests to new validator module in plugins/nfs_.
Updated the CI tests.
Passes NFS CI tests
Ignore the spurrious failure in test_008_check_root_dataset_settings.