Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133576 / 25.04 / Convert webui.enclosure.dashboard to api_method #15396

Merged
merged 5 commits into from
Jan 15, 2025
Merged

NAS-133576 / 25.04 / Convert webui.enclosure.dashboard to api_method #15396

merged 5 commits into from
Jan 15, 2025
+20 −2

Conversation

yocalebo
Copy link
Contributor

No description provided.

@yocalebo yocalebo requested a review from a team January 15, 2025 14:00
@bugclerk bugclerk changed the title Convert webui.enclosure.dashboard to api_method NAS-133576 / 25.04 / Convert webui.enclosure.dashboard to api_method Jan 15, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133576

bmeagherix
bmeagherix approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@bmeagherix bmeagherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve albeit with one question

src/middlewared/middlewared/api/v25_04_0/webui_enclosure.py Outdated Show resolved Hide resolved
@truenas truenas deleted a comment from bugclerk Jan 15, 2025
@yocalebo yocalebo merged commit c079cf6 into master Jan 15, 2025
2 checks passed
@yocalebo yocalebo deleted the enc-dashboard branch January 15, 2025 15:09
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creatorcary creatorcary creatorcary left review comments

@themylogin themylogin themylogin left review comments

@bmeagherix bmeagherix bmeagherix approved these changes

Assignees
No one assigned
Labels
jira-low no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yocalebo @bugclerk @themylogin @creatorcary @bmeagherix