NAS-133709 / 25.04 / Do not import middleware API in ZFS process pool #15455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
themylogin
force-pushed
the
fix-performance
branch
3 times, most recently
from
1bb63cd to
a549543
Compare
|
time 3:00 |
bmeagherix
approved these changes
Jan 21, 2025
themylogin
force-pushed
the
fix-performance
branch
from
a549543 to
37418bb
Compare
themylogin
force-pushed
the
fix-performance
branch
from
37418bb to
99a1984
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ZFS process pool was importing pydantic API. Middleware was waiting for it to finish during the startup (as middleware startup calls ZFS modules). The middleware startup time included 3 pydantic API import waits (middleware itself + 3 ZFS workers).
Now, it's only importing pydantic API once.