Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133788 / 25.10 / Turn off tagging when null is passed to ipmi.lan.update.vlan #15484

Merged
merged 2 commits into from
Jan 29, 2025
Merged

NAS-133788 / 25.10 / Turn off tagging when null is passed to ipmi.lan.update.vlan #15484

merged 2 commits into from
Jan 29, 2025

Conversation

creatorcary
Copy link
Contributor

No description provided.

@creatorcary creatorcary requested a review from a team January 24, 2025 20:11
@bugclerk bugclerk changed the title Turn off tagging when null is passed to ipmi.lan.update.vlan NAS-133788 / 25.04 / Turn off tagging when null is passed to ipmi.lan.update.vlan Jan 24, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133788

@truenas truenas deleted a comment from bugclerk Jan 25, 2025
@yocalebo yocalebo changed the title NAS-133788 / 25.04 / Turn off tagging when null is passed to ipmi.lan.update.vlan NAS-133788 / 25.10 / Turn off tagging when null is passed to ipmi.lan.update.vlan Jan 27, 2025
mgrimesix
mgrimesix approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mgrimesix mgrimesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like the small readability improvement.

@creatorcary creatorcary merged commit 98ba0b5 into master Jan 29, 2025
2 checks passed
@bugclerk bugclerk mentioned this pull request Jan 29, 2025
Merged
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133788 is targeted to the following versions which have not received their corresponding PRs: 25.10

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 29, 2025
@creatorcary creatorcary deleted the vlan-tagging branch January 29, 2025 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgrimesix mgrimesix mgrimesix approved these changes

Assignees
No one assigned
Labels
backport-25.04-RC.1 backported jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@creatorcary @bugclerk @mgrimesix @yocalebo