NAS-133844 / 25.04-RC.1 / validate download token generation (by anodos325) #15509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds validation that API user request to generate an authentication token for a job only succeeds if the job was initiated by the currently authenticated user. This commit also adds auditing for when authenticated sessions generate API tokens. (cherry picked from commit 1e511c0)
anodos325
approved these changes
Jan 28, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds validation that API user request to generate an authentication token for a job only succeeds if the job was initiated by the currently authenticated user.
This commit also adds auditing for when authenticated sessions generate API tokens.
Original PR: #15508
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133844