Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133870 / 25.10 / Give proper error response to STIG auth #15525

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

anodos325
Copy link
Contributor

We need to reply with a generic AUTH_ERR response rather than a CallError on authentication failure in STIG mode. We can't provide more details due to security considerations, but we can give a useful log message for admins.

We need to reply with a generic AUTH_ERR response rather than
a CallError on authentication failure in STIG mode. We can't
provide more details due to security considerations, but we
can give a useful log message for admins.
@bugclerk bugclerk changed the title Give proper error response to STIG auth NAS-133870 / 25.10 / Give proper error response to STIG auth Jan 30, 2025
@bugclerk
Copy link
Contributor

@anodos325 anodos325 requested a review from a team January 30, 2025 03:44
Copy link
Contributor

@mgrimesix mgrimesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anodos325 anodos325 merged commit c29058c into master Feb 3, 2025
2 checks passed
@anodos325 anodos325 deleted the NAS-133870 branch February 3, 2025 18:03
@bugclerk
Copy link
Contributor

bugclerk commented Feb 3, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants