NAS-133676 / 25.04-RC.1 / Check/add search elements for new pages (by AlexKarpov98) #11424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should reset it
(cherry picked from commit b14caa9)
AlexKarpov98
requested review from
denysbutenko
and removed request for
a team
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
❌ Your patch status has failed because the patch coverage (72.41%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## stable/fangtooth #11424 +/- ##
===================================================
Coverage ? 83.00%
===================================================
Files ? 1676
Lines ? 60150
Branches ? 6325
===================================================
Hits ? 49930
Misses ? 10220
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…133676-25.04-RC.1 # Conflicts: # src/app/pages/virtualization/components/all-instances/instance-details/instance-details.component.html # src/app/pages/virtualization/components/all-instances/instance-details/instance-details.component.ts # src/assets/i18n/es-ar.json # src/assets/i18n/ko.json # src/assets/i18n/nl.json # src/assets/i18n/zh-hans.json
…133676-25.04-RC.1 # Conflicts: # src/assets/i18n/es-ar.json # src/assets/i18n/ko.json # src/assets/i18n/nl.json # src/assets/i18n/zh-hans.json
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Testing: see ticket.
New search elements should be available now.
Original PR: #11415
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133676