Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133655 / 25.04-RC.1 / Pass location.hostname as host_ip to app.query #11456

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Feb 1, 2025

Backport of #11356

@undsoft undsoft requested a review from a team as a code owner February 1, 2025 15:36
@undsoft undsoft requested review from RehanY147 and removed request for a team February 1, 2025 15:36
@bugclerk bugclerk changed the title NAS-133655: Pass location.hostname as host_ip to app.query NAS-133655 / 25.04-RC.1 / Pass location.hostname as host_ip to app.query Feb 1, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Feb 1, 2025

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@c612081). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/app/pages/apps/services/applications.service.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11456   +/-   ##
===================================================
  Coverage                    ?   83.00%           
===================================================
  Files                       ?     1676           
  Lines                       ?    60152           
  Branches                    ?     6325           
===================================================
  Hits                        ?    49932           
  Misses                      ?    10220           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit c8b9b78 into stable/fangtooth Feb 2, 2025
9 checks passed
@undsoft undsoft deleted the NAS-133655 branch February 2, 2025 14:21
@bugclerk
Copy link
Contributor

bugclerk commented Feb 2, 2025

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133655 is targeted to the following versions which have not received their corresponding PRs: 25.10

@bugclerk
Copy link
Contributor

bugclerk commented Feb 2, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants