Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only fetch completed feedback results #1742

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

only fetch completed feedback results #1742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/trulens/core/database/sqlalchemy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,11 @@ def get_records_and_feedback(
self.orm.AppDefinition.app_name == app_name
)

stmt = stmt.options(joinedload(self.orm.Record.feedback_results))
# Only load feedback results where the status column is "done".
stmt = stmt.join(self.orm.Record.feedback_results).filter(
self.orm.FeedbackResult.status
== feedback_schema.FeedbackResultStatus.DONE.value
)
stmt = stmt.options(joinedload(self.orm.Record.app))
# NOTE(piotrm): The joinedload here makes it so that the
# feedback_results and app definitions get loaded eagerly instead if lazily when
Expand Down
Loading