Update Snowflake OTEL E2E tests to use Snowflake runs. #1849
+130
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| app = tests.unit.test_otel_tru_custom.TestApp() | ||
| tru_recorder = TruApp( | ||
| app_name = str(uuid.uuid4()) | ||
| app_name = app_name.upper() # TODO(this_pr): Remove this requirement or give a better error message! |
There was a problem hiding this comment.
Consider refactoring the enforced uppercase transformation for app_name. Either remove the requirement or raise a meaningful error instead of silently modifying the name.
…date_e2e_tests_to_use_snowflake_runs
This reverts commit afff563.
… only have one input_df as that's required.
…date_e2e_tests_to_use_snowflake_runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Snowflake OTEL E2E tests to use Snowflake runs.
Other details good to know for developers
Type of change
not work as expected)
Important
Refactor Snowflake OTEL E2E tests to use a standardized
_test_tru_appfunction and update return types for consistency._test_tru_appfunction intest_snowflake_event_table_exporter.pyto standardize test execution for different apps.test_tru_custom_app,test_tru_llama,test_tru_chain, andtest_feedback_computationto use_test_tru_app._wait_for_num_resultsand_validate_resultstoList[Row]intest_snowflake_event_table_exporter.py.Any,Callable,Dict,Tuple,Type, andpdintest_snowflake_event_table_exporter.py.This description was created by
for 665e564. It will automatically update as commits are pushed.