Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

feat: Fetch the provider name from custom request url #127

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

talwinder50
Copy link
Member

closes #126

Signed-off-by: talwinder kaur [email protected]

@cla-bot cla-bot bot added the cla-signed label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #127 (7c8a9f5) into main (ca0f8aa) will increase coverage by 0.24%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   89.25%   89.49%   +0.24%     
==========================================
  Files           9        9              
  Lines         856      876      +20     
==========================================
+ Hits          764      784      +20     
  Misses         66       66              
  Partials       26       26              
Impacted Files Coverage Δ
pkg/restapi/operation/operations.go 94.42% <88.88%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0f8aa...7c8a9f5. Read the comment docs.

@talwinder50 talwinder50 force-pushed the issue-126 branch 2 times, most recently from c90548c to 8249dee Compare June 24, 2021 23:07
Copy link
Member

@rolsonquadras rolsonquadras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a BDD tests as well as this is going to be the main flow going forward ?

@talwinder50
Copy link
Member Author

Can we add a BDD tests as well as this is going to be the main flow going forward ?

#128 created this issue. I will add that as the follow up task

@rolsonquadras rolsonquadras merged commit 12b0aa0 into main Jun 25, 2021
@rolsonquadras rolsonquadras deleted the issue-126 branch June 25, 2021 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch the provider name from custom request url
3 participants