[WIP] It breaks when prepared statements are disabled #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ActiveRecord SQL Query Comments is enabled, AR will automatically disable prepared statements.
Without prepared statements, a test breaks like here: https://github.com/trusted/iron_trail/actions/runs/13052410073/job/36415455364
The fix is easy and just constitutes in converting the incoming value to a string, since the
->>
JSON operator in PostgreSQL always returns a string, no matter the value type in the json object.I don't know how to properly test this, so I'm leaving it here for now.
The fix could be just to change the line at `` from:
but what if
value
is nil?Asana link