Update test files for unit tests #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlangevin
approved these changes
Nov 6, 2024
…ths where needed.
jtlangevin
force-pushed
the
unit_test_files
branch
from
cd4a8ba to
6f95cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that unit tests depend only on data in
tests/test_files, and not user data such as/ecm_definitionswhich might change with project-specific branches. Some file paths have been updated in the code to make this possible.One minor feature is also added to remove ECMs from the
ecm_filesargument inecm_prep_args.py, instead of catching that inecm_prep.py(https://github.com/trynthink/scout/pull/436/files#diff-2372518dd4f83c63eb5d865655069cd8e2e557dd41be361b3ed267554c2837ffR49). A unit test,test_missing_ecmsis added to cover that.