Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abubaker779/ ( issue-#375 ) now persistent callback url across navigation. #379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Abu-bkr
Copy link

@Abu-bkr Abu-bkr commented Nov 19, 2024

Description

The issue is the when coming from Pear AI desktop app to the signin page it contains URL parameter but it does not persist
when navigating to signup page

may be some users do not have account on https://pear.ai, so they have to signup first.

Related Issue

there was an issue related to this paprticular one but it was closed without being fixed.
so, I have opened an issue #375 that show that this particular problem of callback URL not persisting across navigations.

fixes - #375

Changes Made

I have made chages to the files

  1. components/auth/signin.tsx
  2. components/auth/signup.tsx
  3. components/ui/authbutton.tsx
  4. components/ui/mobile-menu.tsx
  5. hooks/useSigningUrl.ts ( added this file as hook. )

Files from 1 to 4 are modified and filenumber 5 ( new hook ) is added.

Screenshot 2024-11-19 194202

In order to use this hook we just need to call it in the file where sigin or signup url is needed.
like this ...
image

And use this as
image

Screenshots

Screen.Recording.2024-11-17.184748.mp4

Checklist

  • I have tagged the issue in this PR.
  • I have attached necessary screenshots.
  • I have provided a short description of the PR.
  • I ran yarn build and build is successful
  • My code follows the style guidelines of this project.
  • I have added necessary documentation (if applicable)

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pear-landing-page ❌ Failed (Inspect) Nov 30, 2024 0:41am
pear-landing-page-main ❌ Failed (Inspect) Nov 30, 2024 0:41am

Copy link

vercel bot commented Nov 19, 2024

@Abubaker779 is attempting to deploy a commit to the PearAI Team on Vercel.

A member of the Team first needs to authorize it.

@Fryingpannn
Copy link
Contributor

hmm currently when user signs in from app, they can login and then the popup appears to auth in app from callback

however, if user must sign up first, then the callback is not persisted. and even with this change, there's no callback for sign up, need to be added from app.

however, there's no persistence from after user signs up to dashboard page. the expected behaviour would be if user clicks signs up from app, after sign up completes, it brings to dashboard which still prompts to open app. but tbh a bit difficult since user could be signing up from their own email, which requires verification and that's a separate context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants