Fixes/issue#388

[VishalRpR]

Description

When user subscribes, on the success page, call the same function as when they click "Open App" in their dashboard, so the app has the updated JWT

Related Issue

#388

Changes Made

Abstracted the Successpage as client side conponent and called the funtion for open App when user reaches success page on dashboard

Screenshots

Checklist

• I have tagged the issue in this PR.
• I have attached necessary screenshots.
• I have provided a short description of the PR.
• I ran yarn build and build is successful
• My code follows the style guidelines of this project.
• I have added necessary documentation (if applicable)

---

Important

Abstracts success page into SuccessCard component and updates JWT on subscription success by calling openApp.

• Behavior:
  • Abstracts success page into SuccessCard component in success-card.tsx.
  • Calls openApp function on subscription success to update JWT.
• Functions:
  • openApp in SuccessCard constructs callback URL and navigates using router.push().
  • Handles errors with toast.error() if URL is unsafe or navigation fails.
• Data Fetching:
  • getUserAndSubscription used in DashboardSuccess to fetch query params for app opening.

^{This description was created by for 19576d2. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pear-landing-page	❌ Failed (Inspect)			Dec 9, 2024 11:59am
pear-landing-page-dev	❌ Failed (Inspect)			Dec 9, 2024 11:59am
pear-landing-page-main	❌ Failed (Inspect)			Dec 9, 2024 11:59am

[vercel]

@VishalRpR is attempting to deploy a commit to the PearAI Team on Vercel.

A member of the Team first needs to authorize it.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 19576d2 in 1 minute and 36 seconds

More details

• Looked at 120 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. components/dashboard/success-card.tsx:22

• Draft comment:
  Ensure openAppQueryParams is a string before concatenating it with DEFAULT_OPEN_APP_CALLBACK. If it's a URLSearchParams, convert it to a string first.
• Reason this comment was not posted:
  Comment did not seem useful.

2. components/dashboard/success-card.tsx:27

• Draft comment:
  Ensure isAllowedUrl function is robust and correctly identifies unsafe URLs. Review its implementation if necessary.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_vtnLJ3OmtN4jHJw3

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

This constant is duplicated. Consider defining it in a shared constants file and importing it where needed.

• constant DEFAULT_OPEN_APP_CALLBACK (freetrial-card.tsx)

[Fryingpannn]

Let's reuse existing variable

[Fryingpannn]

The changes you made seems to only call this callback open functionality for subscription upgrades. We want this for when the user purchases a subscription, not just for upgrades.

[Fryingpannn]

Let's reuse existing variable

[VishalRpR]

@Fryingpannn looking into it!

[VishalRpR]

Reusing the existing variables along with the functionality on pricing/success page as well

[VishalRpR]

@nang-dev