Fix: only show Current File for file scheme editors (#255)

Prevents invalid file paths from appearing in the Current File button when clicking on non-file editors like Output panel or Terminal. Now checks editor's URI scheme to ensure it's a valid file before updating the active file path. Co-authored-by: cwilliams <[email protected]>
trypear · Jan 31, 2025 · 47242a3 · 47242a3
1 parent b5e5732
commit 47242a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/extensions/vscode/src/ideProtocol.ts b/extensions/vscode/src/ideProtocol.ts
@@ -66,7 +66,7 @@ class VsCodeIde implements IDE {
 
   onDidChangeActiveTextEditor(callback: (filepath: string) => void): void {
     vscode.window.onDidChangeActiveTextEditor((editor) => {
-      if (editor) {
+      if (editor?.document.uri.scheme === 'file') {
         callback(editor.document.uri.fsPath);
       }
     });

diff --git a/gui/src/redux/slices/uiStateSlice.ts b/gui/src/redux/slices/uiStateSlice.ts
@@ -58,7 +58,8 @@ export const uiStateSlice = createSlice({
       state.displayBottomMessageOnBottom = action.payload;
     },
     setActiveFilePath: (state, action: PayloadAction<UiState["activeFilePath"]>) => {
-      state.activeFilePath = action.payload ?? "";
+      // Only set non-empty strings as active file paths
+      state.activeFilePath = action.payload && action.payload.length > 0 ? action.payload : undefined;
     },
   },
 });