Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react dev inspector #238

Merged
merged 2 commits into from
Jan 15, 2025
Merged

react dev inspector #238

merged 2 commits into from
Jan 15, 2025

Conversation

Himanshu-Singh-Chauhan
Copy link

@Himanshu-Singh-Chauhan Himanshu-Singh-Chauhan commented Jan 15, 2025

Important

Add react-dev-inspector to enable component inspection in development environment.

  • Dependencies:
    • Add react-dev-inspector to devDependencies in package.json.
  • Main Application:
    • Import Inspector from react-dev-inspector in main.tsx.
    • Conditionally render <Inspector /> in main.tsx when NODE_ENV is development.

This description was created by Ellipsis for 502f238. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 4117b32 in 43 seconds

More details
  • Looked at 29 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_PLTbWlK0Xt0PbVgb


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

gui/src/main.tsx Outdated Show resolved Hide resolved
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 502f238 in 14 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. gui/src/main.tsx:15
  • Draft comment:
    The change from ?? to ? : null is correct. ?? is the nullish coalescing operator and not suitable for conditional rendering. The ternary operator ? : is appropriate here.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from ?? to ? : null is correct as ?? is not the right operator for conditional rendering.

Workflow ID: wflow_YBqFEHpzHw7ozMBo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Himanshu-Singh-Chauhan Himanshu-Singh-Chauhan merged commit 130eca8 into main Jan 15, 2025
2 checks passed
nang-dev pushed a commit that referenced this pull request Feb 4, 2025
* react dev inspector

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant