Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Option #70

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

a-augustin
Copy link

Description ✏️

I added the feedback page in the submodule.

Checklist ✅

Screen Shot 2024-10-28 at 12 18 46 AM
Screen Shot 2024-10-28 at 12 19 02 AM

  • [ x] I have added screenshots (if UI changes are present).
  • [ x] I have done a self-review of my code.
  • I have manually tested my code (if applicable).

@nang-dev
Copy link

nang-dev commented Oct 29, 2024

Ohhh sorry augustin. we should have it be automatic! so theyre already signed in. client side (the app) can just send their api key and the feedback as text. so just one box -> feedback and one button -> send. and we should have auto close, with a vscode notif in the bottom right that says "Feedback sent successfully!" (or error)

so basically:

  1. see if user is signed in (look at the pearai credentials), if not, ask them to sign in to submit feedback
  2. send headers (https://github.com/trypear/pearai-submodule/blob/main/core/continueServer/stubs/headers.ts#L4
    ), api-key (see PearAIServer.ts), and feedback to SERVER_URL/client_feedback

my bad for not making this clear earlier

@a-augustin
Copy link
Author

No worries! I’ll make the changes. Thanks for the feedback

@a-augustin
Copy link
Author

I updated the feedback page with just the text box and the vscode notifications when the user submits. I also added the headers and API key to the endpoint you mentioned. If there are any issues, let me know.

gui/src/App.tsx Outdated
Comment on lines 24 to 26
const router = createMemoryRouter([
{
initialEntries: [window.isPearOverlay ? "/inventory" : window.initialRoute],
path: "/",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is all this removed?

gui/src/App.tsx Outdated
Comment on lines 90 to 93
{
path: "/feedback",
element: <Feedback/>,
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just add /feedback route here, leave the rest as it is 😄

"/aiderMode",
"/inventory",
"/inventory/aiderMode",
"/inventory/perplexityMode"
];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont remove these, we want to hide footers on those routes

Copy link
Author

@a-augustin a-augustin Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove those footer line, I'm not sure how they were removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants