Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor styling tweaks: #98

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Conversation

cassiozen
Copy link
Contributor

Applied piccalil.li modern CSS Reset (Defaults to border-box box sizing & includes chosen font in form fields, buttons etc)
Include swyx.io 100 Bytes of CSS to look great everywhere

piccalil.li's modern CSS Reset
swyx.io's 100 Bytes of CSS to look great everywhere
@tsileo
Copy link
Owner

tsileo commented Nov 9, 2022

Hi!

Thank you for your contribution.

I thought the pull requests were disabled on this repository, as all the contributions happen on sourcehut (https://sr.ht/~tsileo/microblog.pub/).
I can treat this PR as patch since your were able to open it though.

I am curious, what tools did you use to format the CSS file?

Did you notice any significant changes with these changes?

Thanks!

@tsileo
Copy link
Owner

tsileo commented Nov 9, 2022

I tried to apply it on one of my instance, it mostly looks good.

I think I would tweak it the top/bottom padding on html to 1 em as I think it feels weird to have so much padding on the top/bottom, any thoughts on that?

@cassiozen
Copy link
Contributor Author

I can treat this PR as patch since your were able to open it though.

Thanks, I completely forgot this was a mirror repo.

I am curious, what tools did you use to format the CSS file?

I used Prettier

Did you notice any significant changes with these changes?

I tested on my test setup (cassiozen.fly.dev) and it's subtle. Haven't noticed any big changes.

@cassiozen
Copy link
Contributor Author

I tried to apply it on one of my instance, it mostly looks good.

I think I would tweak it the top/bottom padding on html to 1 em as I think it feels weird to have so much padding on the top/bottom, any thoughts on that?

Yeah, now that you mentioned I do think top/bottom margin should be smaller (because microblog has both a menu and a footer)

@tsileo
Copy link
Owner

tsileo commented Nov 13, 2022

Sounds good, I think I will apply the patch locally (and bypass GH) + make some tweaks, but I noticed there will be some other details that needs to be fixed (like custom error pages, the CSS was already a bit hazardous).

I haven't got time today as I was fixing some bugs preventing to process activities.

I will do some more testing early next week!

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants