Update phpunit dep for phpstan

Signed-off-by: Kevin Decherf <[email protected]>
tsknadaj · Aug 5, 2021 · 9a4ff85 · 9a4ff85
1 parent 6a044f8
commit 9a4ff85
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -8,6 +8,6 @@ parameters:
         container_xml_path: %rootDir%/../../../var/cache/test/appTestDebugProjectContainer.xml
 
     bootstrapFiles:
-        - vendor/bin/.phpunit/phpunit-8.3-0/vendor/autoload.php
+        - vendor/bin/.phpunit/phpunit-8.5-0/vendor/autoload.php
 
     inferPrivatePropertyTypeFromConstructor: true
diff --git a/src/Wallabag/CoreBundle/ParamConverter/UsernameFeedTokenConverter.php b/src/Wallabag/CoreBundle/ParamConverter/UsernameFeedTokenConverter.php
@@ -87,5 +87,7 @@ public function apply(Request $request, ParamConverter $configuration)
 
         // Map found user to the route's parameter
         $request->attributes->set($configuration->getName(), $user);
+
+        return true;
     }
 }
diff --git a/src/Wallabag/UserBundle/Entity/User.php b/src/Wallabag/UserBundle/Entity/User.php
@@ -373,13 +373,15 @@ public function getClients()
     /**
      * Only used by the API when creating a new user it'll also return the first client (which was also created at the same time).
      *
-     * @return Client
+     * @return Client|false
      */
     public function getFirstClient()
     {
         if (!empty($this->clients)) {
             return $this->clients->first();
         }
+
+        return false;
     }
 
     /**