revert runner

tstirrat · Jul 28, 2024 · be60373 · be60373
1 parent 652228a
commit be60373
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/tests/bgb_get_snapshot.py b/tests/bgb_get_snapshot.py
@@ -41,25 +41,21 @@ def make_and_run(rom_relative):
     rom_path_full = base_path.joinpath(rom_relative)
     screenshot_path = rom_path_full.with_suffix('.bmp')
 
-    result = subprocess.call([
+    subprocess.run([
         "../bgb/bgb64.exe",
         "-set \"DebugSrcBrk=1\"",
         "-hf",
         "-stateonexit",
-        "-screenonexit",  screenshot_path,
+        "-screenonexit", screenshot_path,
         rom_relative,
     ],
         cwd=base_dir,
         # stdout=subprocess.DEVNULL,
         # stderr=subprocess.DEVNULL,
     )
 
-    if result != 0:
-        raise Exception("Rom execution failed " + rom_relative)
-
     if not rom_path_full.with_suffix(".sna").is_file():
-        raise Exception(
-            "Snapshot not found after execution " + rom_relative)
+        raise Exception("Tried to run rom, failed " + rom_relative)
 
 
 def make_rom(rom_relative):