Stop watchers before reconnecting to free their resources #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Jun 19, 2017
| @@ -321,6 +339,7 @@ func (c *KubernetesClient) Watch() error { | |||
| } | |||
|
|
|||
| if !more { | |||
| c.stopWatchers() | |||
There was a problem hiding this comment.
In this Watch function, should it be added a defer func() (as in connect function) to stop watchers too?
There was a problem hiding this comment.
Good point, probably the first call to something like the connect method should be made here in Watch (and not in the constructor) as at the end it the only stateful things it creates are the watchers.
I'll do another PR with some refactorizations about this.
mrodm
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stop the watchers when reconnecting. If not, their channels and other resources are not freed, related to #13.