fix: ensure that file references are fixed for filesystem synchronized root groups #897
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors add @bryansum for code |
|
I've put up a pull request to add @bryansum! 🎉 |
fortmarek
approved these changes
Jan 22, 2025
fortmarek
changed the title
|
Thanks again for this PR! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Noticed that when building projects with the new filesystem synchronized root groups that I wasn't seeing references fixed correctly. This seems like an oversight to #827, which had tests for decoding / encoding and for equality testing but none for this in particular.
Solution 📦
This adds an additional check to
ReferenceGeneratorfor any filesystem synchronized root groups starting from the main group, or recursively any children.Implementation 👩💻👨💻
ReferenceGeneratorfixing any filesystem synchronized root group object referencesReferenceGeneratorTeststo ensure that this is working correctly.