bindings/go Support blob types in query arguments, free non-gc allocations #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
force-pushed
the
go_bindings
branch
from
4f2e9b3 to
d03ed35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/adds support for the Blob type and adds the appropriate tests.
Types created on the Go side will be cleaned up rather quickly if nothing is referencing them, so this approach uses
runtime.Pinnerto pin the bytes in memory so the pointers will be valid when Rust usesfrom_raw_partsand then owns a new vec. They are then cleaned up after the FFI call withpinner.Unpin.